yezhengmao/nccl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix out-of-bounds read in ncclStrToCpuset (#233)

Browse Source 
The affinityStr string was not null-terminated but was passed to strlen(3).

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
This commit is contained in:
Felix Abecassis 2019-06-21 01:25:08 -07:00 committed by Sylvain Jeaugey
parent 6d8b2421bc
commit 37e4f8729e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/init.cc
View File

@ -879,10 +879,12 @@ static ncclResult_t getCpuGpuAffinity(int cudaDev, cpu_set_t* mask) {
path[PATH_MAX-1] = '\0'; path[PATH_MAX-1] = '\0';
int fd; int fd;
SYSCHECKVAL(open(path, O_RDONLY), "open", fd); SYSCHECKVAL(open(path, O_RDONLY), "open", fd);
char affinityStr[sizeof(cpu_set_t)*2]; char affinityStr[sizeof(cpu_set_t)*2 + 1];
int r = read(fd, affinityStr, sizeof(cpu_set_t)*2); int r = read(fd, affinityStr, sizeof(cpu_set_t)*2);
if (r > 0) if (r > 0) {
affinityStr[r] = '\0';
NCCLCHECK(ncclStrToCpuset(affinityStr, mask)); NCCLCHECK(ncclStrToCpuset(affinityStr, mask));
}
close(fd); close(fd);
free(cudaPath); free(cudaPath);
return ncclSuccess; return ncclSuccess;