yezhengmao/nccl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a comment to shutdown() in ncclSocketClose

Browse Source
This commit is contained in:
Kaiming Ouyang 2023-04-13 09:00:59 -07:00
parent 367e9b61c3
commit 006b6bc7dc
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/misc/socket.cc
View File

@ -819,6 +819,10 @@ ncclResult_t ncclSocketTryRecv(struct ncclSocket* sock, void* ptr, int size, int
ncclResult_t ncclSocketClose(struct ncclSocket* sock) { ncclResult_t ncclSocketClose(struct ncclSocket* sock) {
if (sock != NULL) { if (sock != NULL) {
if (sock->fd >= 0) { if (sock->fd >= 0) {
/* shutdown() is needed to send FIN packet to proxy thread; shutdown() is not affected
* by refcount of fd, but close() is. close() won't close a fd and send FIN packet if
* the fd is duplicated (e.g. fork()). So shutdown() guarantees the correct and graceful
* connection close here. */
shutdown(sock->fd, SHUT_RDWR); shutdown(sock->fd, SHUT_RDWR);
close(sock->fd); close(sock->fd);
} }